-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for adding ScaleIO PV documentation in volumes.md #2845
PR for adding ScaleIO PV documentation in volumes.md #2845
Conversation
@mikedanese Hi, any chance someone can take a look at this PR. Thanks. |
@vladimirvivien FYI we moved Volumes to /docs/concepts/storage/volumes.md, which is why there is a merge conflict. If you can apply your changes to the document in the new location, I can merge it after a tech review lgtm. |
docs/user-guide/volumes.md
Outdated
ScaleIO is a software-based storage platform that can use existing hardware to create clusters of scalable | ||
shared block networked storage. The ScaleIO volume plugin allows deployed pods to access existing ScaleIO | ||
volumes (or it can dynamically provision new volumes for persistent volume claims, see | ||
[ScaleIO Persistent Volumes](./persistent-volumes/index.md#scaleio)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this document has moved, you'll probably want to use a less relative URL for the link:
/docs/user-guide/persistent-volumes/#scaleio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenopis the doc has been moved to concepts/docs/storage
and the relative links fixed. Looking for LGTM. Thanks.
@chenopis @mikedanese this PR is ready for review, looking for LGTM for merge. Thanks. |
Tech LGTM |
This PR adds PV documentation to volumes.md for ScaleIO volumes. Documentation for PVCs were done in #2741.
This change is